Re: Add FOREIGN to ALTER TABLE in pg_dump

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Luis Carril <luis(dot)carril(at)swarm64(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add FOREIGN to ALTER TABLE in pg_dump
Date: 2020-01-13 15:36:38
Message-ID: 20200113153638.GA17031@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2020-Jan-11, Tomas Vondra wrote:

> Hi,
> On Thu, Sep 26, 2019 at 01:47:28PM +0000, Luis Carril wrote:
> >
> > I don't disagree with adding FOREIGN, though.
> >
> > Your patch is failing the pg_dump TAP tests. Please use
> > configure --enable-tap-tests, fix the problems, then resubmit.
> >
> > Fixed, I've attached a new version.
> This seems like a fairly small and non-controversial patch (I agree with
> Alvaro that having the optional FOREIGN seems won't hurt). So barring
> objections I'll polish it a bit and push sometime next week.

If we're messing with that code, we may as well reduce cognitive load a
little bit and unify all those multiple consecutive appendStringInfo
calls into one. (My guess is that this was previously not possible
because there were multiple fmtId() calls in the argument list, but
that's no longer the case.)

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v3-0001-pg_dump-Add-FOREIGN-to-ALTER-statements-if-approp.patch text/x-diff 9.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2020-01-13 15:46:02 Re: How to retain lesser paths at add_path()?
Previous Message Krasiyan Andreev 2020-01-13 15:22:29 Re: [PATCH] distinct aggregates within a window function WIP