Re: Fixing parallel make of libpq

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing parallel make of libpq
Date: 2020-01-09 06:38:53
Message-ID: 20200109063853.GN2251@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 08, 2020 at 01:33:13PM +0000, Dagfinn Ilmari Mannsåker wrote:
> I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq'
> doesn't work in a clean checkout, because it can't find
> libpgcommon_shlib and libpgport_shlib. It looks like that's because the
> submake-libpgport dependency is declared on the all-lib target, not on
> the shlib itself. Moving it to SHLIB_PREREQS instead fixes it, patch
> for which is attached.

Hmm. That logically makes sense. Isn't that a side effect of 7143b3e
then? Now, FWIW, I am not able to reproduce it here, after trying on
two different machines, various parallel job numbers (up to 32), and a
couple of dozen attempts. Perhaps somebody else can see the failures?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-01-09 06:39:06 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Kyotaro Horiguchi 2020-01-09 06:36:07 Re: Physical replication slot advance is not persistent