| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - use pg logging capabilities |
| Date: | 2020-01-09 04:02:48 |
| Message-ID: | 20200109040248.GF2251@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 08, 2020 at 03:31:46PM +0100, Peter Eisentraut wrote:
> On 2020-01-08 15:12, Michael Paquier wrote:
>> while syntax_error() has been
>> changed in a more modular way.
>
> I don't follow what you mean by that.
The first versions of the patch did not change syntax_error(), and the
version committed has switched to use PQExpBufferData there. I think
that we should just do the same for the debug logs executing the meta
commands. This way, we get an output consistent with what's printed
out for sending or receiving stuff. Please see the attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-logs.patch | text/x-diff | 731 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-09 04:05:45 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Michael Paquier | 2020-01-09 03:09:58 | Re: remove support for old Python versions |