| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, craig(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: xact_start for walsender & logical decoding not updated |
| Date: | 2020-01-07 21:17:17 |
| Message-ID: | 20200107211717.GA20056@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Dec-29, Tomas Vondra wrote:
> On Fri, Dec 27, 2019 at 04:46:18PM -0300, Alvaro Herrera wrote:
> >
> > This patch changes xact.c to avoid updating transaction start timestamps
> > for walsenders (maybe more commentary is desirable). I think logical
> > decoding is just a special form of walsender and thus it would also be
> > updated by this patch, unless I misunderstood what Tomas explained.
> >
>
> It's true walsender should not be doing any read-write transactions or
> executing statements (well, maybe a decoding plugin could, but using
> historic snapshot).
>
> So I agree not leaving xact_start for walsender processes seems OK.
OK, I pushed my patch to branches 10 - master.
(See https://postgr.es/m/20200107211624.GA18974@alvherre.pgsql )
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-01-07 21:36:18 | Re: Removing pg_pltemplate and creating "trustable" extensions |
| Previous Message | Pavel Stehule | 2020-01-07 20:37:55 | Re: jsonb_set() strictness considered harmful to data |