| From: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_recvlogical: Prevent flushed data from being re-sent after restarting replication |
| Date: | 2025-11-24 09:03:41 |
| Message-ID: | 201ed97d-e88c-4c89-9cdf-84aab610e8ba@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
An update: I have two topics from the review perspective.
On the test I proposed to be added to 030_pg_recvlogical.pl, I found a
way to write it without using sleeps (which risk flakyness in CI). I've
attached it as a patch for your consideration. I checked the test in the
following way: on master it fails, but with your patch it passes.
Secondly I noticed in function sendFeedback at line 166, the startpos is
set to output_written_lsn. This seems to counter conceptually the change
you made in the patch, however it seems to not affect correctness. Shall
we remove this line as to avoid confusion?
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-test-for-pg_recvlogical-reconnection.patch | text/plain | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-11-24 09:04:41 | Re: Issue with logical replication slot during switchover |
| Previous Message | 邱宇航 | 2025-11-24 08:47:47 | Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache |