| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andreas Joseph Krogh <andreas(at)visena(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: color by default |
| Date: | 2019-12-31 15:18:00 |
| Message-ID: | 20191231151800.GA3531@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Dec-31, Andreas Joseph Krogh wrote:
> It's easier to spot errors/warnings when they are colored/emphasized imo. Much
> like colored output from grep/diff; We humans have colored vision for a reason.
I do use color output (and find it useful), for that reason.
I'm not sure that the documentation addition properly describes the
logic to be used; if it does, I'm not sure that the logic is really what
we want. Is the logic in the docs supposed to be "last rule that
matches wins" or "first rule that matches wins"? I think that should be
explicit. Do we want to have NO_COLORS override the TERM heuristics?
(I'm pretty sure we do.) OTOH we also want PG_COLORS to override
NO_COLORS.
Per https://no-colors.org (thanks for the link) it seems pretty clear
that people who don't want colors should be already setting NO_COLORS,
and everyone would be happy. It's not just PG programs that are
colorizing stuff.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Isaac Morland | 2019-12-31 15:46:43 | Re: color by default |
| Previous Message | Andreas Joseph Krogh | 2019-12-31 14:12:34 | Re: color by default |