Re: [HACKERS] [PATCH] Generic type subscripting

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: 2019-12-19 14:20:30
Message-ID: 20191219142030.uc6en2ci3rx2jc4c@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Sun, Nov 10, 2019 at 01:32:08PM +0100, Dmitry Dolgov wrote:
> > I had to write new assignment logic reusing only some parts of setPath(),
> > because the loop in setPath() should be broken on every level. During this
> > process, I decided to implement assignment behavior similar to PostgreSQL's
> > array behavior and added two new features:
> > - creation of jsonb arrays/objects container from NULL values
> > - appending/prepending array elements on the specified position, gaps filled
> > with nulls (JavaScript has similar behavior)
> What is the reason for the last one?

I've splitted the last patch into polymorphic itself and jsonb array
behaviour changes, since I'm afraid it could be a questionable part.

Attachment Content-Type Size
v29-0001-Base-implementation-of-subscripting-mechanism.patch text/x-diff 48.2 KB
v29-0002-Subscripting-for-array.patch text/x-diff 24.8 KB
v29-0003-Subscripting-for-jsonb.patch text/x-diff 33.4 KB
v29-0004-Subscripting-documentation.patch text/x-diff 20.0 KB
v29-0005-Polymorphic-subscripting.patch text/x-diff 61.6 KB
v29-0006-Filling-gaps-in-jsonb-arrays.patch text/x-diff 8.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-12-19 14:32:56 Re: obsolete comment in ExecBRUpdateTriggers()
Previous Message Robert Haas 2019-12-19 14:08:16 Re: non-exclusive backup cleanup is mildly broken