| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automating pg_config.h.win32 maintenance |
| Date: | 2019-12-19 07:49:44 |
| Message-ID: | 20191219074944.GC45286@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 19, 2019 at 08:31:05AM +0100, Peter Eisentraut wrote:
> On 2019-12-19 04:59, Michael Paquier wrote:
>> This part needs a comment. Like it is the equivalent of what
>> src/common/'s Makefile does or something like that?
>
> This was meant to be addressed by <https://www.postgresql.org/message-id/flat/6e457870-cef5-5f1d-b57c-fc89cfb8a788%402ndquadrant.com>,
> but that discussion has not concluded yet. Perhaps it makes more sense in
> this context.
Hmm. Your patch does not really change the generation of
VAL_CONFIGURE in pg_config.h, so I am not sure that this other thread
is an actual barrier for the improvement discussed here. I would be
actually fine to just remove the XXX and still use GetFakeConfigure()
with VAL_CONFIGURE for now. It would be a good thing to get rid of
pg_config.h.win32 definitely.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jose Luis Tallon | 2019-12-19 08:48:40 | Re: Proposal: Global Index |
| Previous Message | Peter Eisentraut | 2019-12-19 07:31:05 | Re: automating pg_config.h.win32 maintenance |