Re: pgsql: Refactor attribute mappings used in logical tuple conversion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: er <er(at)xs4all(dot)nl>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor attribute mappings used in logical tuple conversion
Date: 2019-12-18 08:15:14
Message-ID: 20191218081514.GA325369@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Dec 18, 2019 at 08:43:47AM +0100, er wrote:
> gcc (9.2.0) mutters this:
>
> tupconvert.c: In function ‘execute_attr_map_tuple’:
> tupconvert.c:146:8: warning: unused variable ‘outnatts’ [-Wunused-variable]
> 146 | int outnatts = map->outdesc->natts;
> | ^~~~~~~~
>
> (Otherwise compiles & runs fine.)

This one could use a PG_USED_FOR_ASSERTS_ONLY to work properly, but it
is more simple to just remove the variable. Thanks for the report,
Erik.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2019-12-18 08:16:43 Re: pgsql: Partially deduplicate interrupt handling for background processe
Previous Message Peter Eisentraut 2019-12-18 08:14:21 pgsql: Add .editorconfig