Re: [PATCH] Tiny optimization.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Tiny optimization.
Date: 2019-12-18 01:37:33
Message-ID: 20191218013733.GG30116@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 23, 2019 at 10:44:47AM +0100, Andreas Karlsson wrote:
> On 11/22/19 10:58 PM, Ranier Vilela wrote:
> > Remove redutant test.
>
> Yeah, this test does look redundant since we already check for if parent is
> NULL earlier in the function. Any optimizing compiler should see this too,
> but it is still a good idea to remove it for code clarity.

Agreed, patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-12-18 01:53:37 Re: RFC: split OBJS lines to one object per line
Previous Message Peter Geoghegan 2019-12-18 01:29:27 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.