Re: non-exclusive backup cleanup is mildly broken

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: masao(dot)fujii(at)gmail(dot)com
Cc: robertmhaas(at)gmail(dot)com, david(at)pgmasters(dot)net, magnus(at)hagander(dot)net, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org
Subject: Re: non-exclusive backup cleanup is mildly broken
Date: 2019-12-17 06:30:52
Message-ID: 20191217.153052.397413637231450925.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 17 Dec 2019 15:11:55 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Tue, 17 Dec 2019 11:46:03 +0900, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote in
> PREPARE. The attached does that and changes the if condition of
> cancel_before_shmem_exit into assertion.

The patch can cause removal of a wrong cleanup function on non-cassert
build. That might be unwanted. But I think the assertion is needed
anyway.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-12-17 06:47:07 empty column name in error message
Previous Message Michael Paquier 2019-12-17 06:30:38 Re: automating pg_config.h.win32 maintenance