Re: REINDEX CONCURRENTLY unexpectedly fails

On 2019-Nov-20, Michael Paquier wrote:

> diff --git a/src/include/catalog/index.h b/src/include/catalog/index.h
> index 1113d25b2d..04d3d4826f 100644
> --- a/src/include/catalog/index.h
> +++ b/src/include/catalog/index.h
> @@ -113,6 +113,8 @@ extern bool CompareIndexInfo(IndexInfo *info1, IndexInfo *info2,
>
> extern void BuildSpeculativeIndexInfo(Relation index, IndexInfo *ii);
>
> +extern bool RelationSupportsConcurrently(char relpersistence);
> +
> extern void FormIndexDatum(IndexInfo *indexInfo,
> TupleTableSlot *slot,
> EState *estate,

I liked Andres' original naming suggestion better FWIW. With this, one
wonders "concurrently what?"

> +/*
> + * RelationSupportsConcurrently
> + *
> + * Check if a relation supports concurrent builds or not. This is
> + * used as a sanity check prior processing CREATE INDEX, DROP INDEX
> + * or REINDEX when using CONCURRENTLY.
> + */

Some suggestions,
"RelationSupportsConcurrentIndexing" or
"IndexSupportsConcurrently". Maybe replace the "ing" in the first or
"ly" in the second with "DDL" or "Ops". (Also, if it's just about
indexes and appears in index.h, why did you use the prefix "Relation"?)

In the indexcmds.c Reindex* routines, why not turn off the "concurrent"
flag?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services