Re: logical decoding bug: segfault in ReorderBufferToastReplace()

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Schneider (AWS), Jeremy" <schnjere(at)amazon(dot)com>
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Date: 2019-12-11 17:21:01
Message-ID: 20191211172101.k55jz364chv77ewh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-committers pgsql-hackers

Hi,

On 2019-12-11 12:11:03 -0500, Tom Lane wrote:
> I don't think you can make that conclusion. Perhaps the table once
> needed a toast table because of some wide column that got dropped;
> if so, it'd still have one. It'd be safer to look at
> pg_class.reltoastrelid to verify existence (or not) of the toast relation.

That was checked in the email I was responding to.

> It strikes me that there could easily be cases where a publisher table
> has a toast relation and a subscriber's doesn't ... maybe this code
> isn't expecting that?

This code is all running on the publisher side, so I don't think it
could matter.

Greetings,

Andres Freund

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Roman Cervenak 2019-12-11 17:23:39 Re: Memory leak (possibly connected to postgis) leading to server crash
Previous Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-12-11 20:10:04 pgsql: Use only one thread to handle incoming signals on Windows.
Previous Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-12-11 17:38:51 Re: global / super barriers (for checksums)
Previous Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()