| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alexey Bashtanov <bashtanov(at)imap(dot)cc>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: log bind parameter values on error |
| Date: | 2019-12-09 20:05:31 |
| Message-ID: | 20191209200531.GA19848@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Also:
* Thoughts from Andres, who was busily messing about with stringinfo.c
on his patch series for programmatic out/read node functions?
* Thoughts on changing the current usage of the ...Quoted() function in
postgres.c and pl_exec.c so that they print N characters (64) instead
of the current default of printing everything? I'm up for changing,
but have got no +1s on that. I think bloating log files with enormous
parameters is pointless.
* v18 and v19 now alwys do a "strlen(s)", i.e. they scan the whole input
string -- pointless when maxlen is given. We could avoid that for
very large input strings by doing strnlen(maxlen + MAX_MULTIBYTE_CHAR_LEN)
so that we capture our input string plus one additional multibyte
char.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-12-09 20:15:22 | Re: log bind parameter values on error |
| Previous Message | Pavel Stehule | 2019-12-09 20:04:21 | Re: proposal: minscale, rtrim, btrim functions for numeric |