Re: [Proposal] Level4 Warnings show many shadow vars

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Proposal] Level4 Warnings show many shadow vars
Date: 2019-12-06 01:11:37
Message-ID: 20191206011137.GD121835@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 05, 2019 at 01:41:20PM -0500, Robert Haas wrote:
> If you do decide to work on this, I recommend against preparing a
> single giant patch that changes every single one blindly. Try to think
> about which cases are the most egregious/dangerous and propose patches
> for those first. If those are accepted then you can move on to other
> cases.

+1. An case-by-case analysis is key here because it depends on the
context of the code. I am ready to bet that we don't care about most
of them, still that there are cases which actually matter a lot.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-12-06 01:33:23 Re: Removal of support for OpenSSL 0.9.8 and 1.0.0
Previous Message Michael Paquier 2019-12-06 00:59:51 Re: Update minimum SSL version