Re: log bind parameter values on error

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Alexey Bashtanov <bashtanov(at)imap(dot)cc>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: log bind parameter values on error
Date: 2019-12-05 18:03:25
Message-ID: 20191205180325.2jscsekp34zzpvms@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-12-05 14:19:45 -0300, Alvaro Herrera wrote:
> What this does is set an error callback, which adds the parameter values
> in the DETAIL line. This is at odds with all existing error callbacks:
> they only add stuff to the CONTEXT string. The implication is that
> if an error site has a direct errdetail_log() and is run under this
> error stack, that site's detail is going to be lost and replaced by the
> "params" one. Currently there aren't many errdetail_log() lines, so it
> doesn't seem like a terrible problem. However, it's something to keep
> in mind.

It'd not be too hard avoiding overwriting if we wanted. Makes me wonder
though, if we ought to invent something similar to the errdata fields we
have for schema, table, etc...

Haven't yet had time to catch up to the discussion in this thread of the
last two weeks...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2019-12-05 18:12:17 Re: Append with naive multiplexing of FDWs
Previous Message Tomas Vondra 2019-12-05 17:51:45 Re: Using multiple extended statistics for estimates