Re: log bind parameter values on error

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Alexey Bashtanov <bashtanov(at)imap(dot)cc>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: log bind parameter values on error
Date: 2019-12-05 17:19:45
Message-ID: 20191205171945.GA28489@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I made a number of changes on the proposed patch and ended up with the
attached. (I have not included the business to limit number of
characters, yet).

What this does is set an error callback, which adds the parameter values
in the DETAIL line. This is at odds with all existing error callbacks:
they only add stuff to the CONTEXT string. The implication is that
if an error site has a direct errdetail_log() and is run under this
error stack, that site's detail is going to be lost and replaced by the
"params" one. Currently there aren't many errdetail_log() lines, so it
doesn't seem like a terrible problem. However, it's something to keep
in mind.

This is not final form; there are a couple of XXX comments, and a number
of other small infelicities still to fix. But the overall idea should
be final.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v15-0001-Add-appendStringInfoStringQuoted.patch text/x-diff 5.4 KB
v15-0002-bashtanov-v14.patch text/x-diff 21.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-12-05 17:51:45 Re: Using multiple extended statistics for estimates
Previous Message Tomas Vondra 2019-12-05 17:15:54 Re: Using multiple extended statistics for estimates