From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Failure in TAP tests of pg_ctl on Windows with parallel instance set |
Date: | 2019-12-02 03:14:44 |
Message-ID: | 20191202031444.GC1696@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
I have run the TAP tests with an instance of Postgres locally set at
port 5432 on Windows, to notice that 001_start_stop.pl fails various
tests because the test tries to use the default port for the node
initialized with pg_ctl. The problem can get fixed easily by
assigning a random port number to that instance.
It could potentially become a problem if parallel TAP tests run in
parallel on Windows while initializing the node because of a port
conflict, but that's actually already a problem now for all the tests
as all nodes listen to 127.0.0.1 in this case. This cannot happen on
*nix simply because we use a unique unix domain path, so even if ports
conflict things are able to work.
Attached is a patch to fix this issue, that I would like to
back-patch down to 9.4 where the issue can show up.
Any objections?
--
Michael
Attachment | Content-Type | Size |
---|---|---|
pgctl-tap-win32.patch | text/x-diff | 653 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | 盏一 | 2019-12-02 04:22:37 | Re:Issue about memory order on ARM |
Previous Message | Amit Langote | 2019-12-02 03:05:06 | Re: Bogus EXPLAIN results with column aliases for mismatched partitions |