Re: Safeguards against incorrect fd flags for fsync()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Safeguards against incorrect fd flags for fsync()
Date: 2019-11-25 07:18:33
Message-ID: 20191125071833.GD99720@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 24, 2019 at 08:18:38PM -0800, Mark Dilger wrote:
> Ok, it passes all regression tests, and I played around with
> intentionally breaking the code to open file descriptors in
> the wrong mode. The assertion appears to work as intended.
>
> I'd say this is ready for commit.

Thanks for the review. I'll look at that pretty soon.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-11-25 07:21:35 Re: refactoring - share str2*int64 functions
Previous Message Michael Paquier 2019-11-25 07:16:38 Re: pg_upgrade fails with non-standard ACL