Re: [PATCH] Style: fix function declaration

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Style: fix function declaration
Date: 2019-11-25 01:05:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Sun, Nov 24, 2019 at 12:47:40PM +0000, Ranier Vilela wrote:
> Fix function declaration .

I see no problem with fixing this kind of inconsistency for
readability, so applied the change.

Anyway, when sending a patch there are a couple of things which can
make the life of people looking at what you send easier:

One problem that I noted with the patch sent on this thread is that it
does not directly apply on the git repository. Folks on -hackers are
mainly used to diffs generated by git. So first I would recommend
that you set up a git repository of the tree, say with that:
git clone

And then you can begin working on the code. On Windows, using git is
a rather straight-foward experience (I have used it and still use it
occasionally because it has its own concept of *nix-like terminal):

Most people use a *nix platform, with either macos, Linux, a BSD
flavor (NetBSD, FreeBSD), etc. Still there are Windows users.
Building the code can be harder than other platforms, but we have
documentation on the matter:

Generating a patch can be done with git in a couple of ways from the
cloned repository, say:
1) git diff
2) git format-patch
Both can be applied with a simple "patch -p1" command or even the more
advanced "git am", still the latter is kind of picky.

The code of Postgres is complex, so usually there are reasons why
things are done the way they are, and it is important to not be afraid
to ask questions. Also, making the subject of the emails you send
explicative enough is important. Please note pgsql-hackers has a lot
of traffic, and this helps some people in filtering out threads they
are not interested in.


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2019-11-25 01:18:28 RE: [PATCH] Style: fix function declaration
Previous Message Michael Paquier 2019-11-25 00:43:59 Re: [PATCH] Do not use StdRdOptions in Access Methods