Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Gilles Darold <gilles(at)darold(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Date: 2019-11-06 07:35:10
Message-ID: 20191106073510.GI1604@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 06, 2019 at 03:12:04PM +0900, Etsuro Fujita wrote:
> On Wed, Nov 6, 2019 at 1:13 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> "postgres_fdw foreign tables" sounds weird to me. Could "foreign
>> tables using postgres_fdw" be a better wording? I am wondering as
>> well if we should not split this information into two parts: one for
>> the actual error message which only mentions foreign tables, and a
>> second one with a hint to mention that postgres_fdw has been used.
>
> We use "postgres_fdw foreign tables" or "postgres_fdw tables" in
> release notes, so I thought it was OK to use that in error messages as
> well. But actually, these wordings are not suitable for error
> messages?

It is true that the docs of postgres_fdw use that and that it is used
in some comments. Still, I found this wording a bit weird.. If you
think that what you have is better, I am also fine to let you have the
final word, so please feel to ignore me :)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-11-06 07:39:14 Re: [proposal] recovery_target "latest"
Previous Message Peter Eisentraut 2019-11-06 07:32:35 Re: pause recovery if pitr target not reached