Re: TAP tests aren't using the magic words for Windows file access

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: TAP tests aren't using the magic words for Windows file access
Date: 2019-11-05 03:41:38
Message-ID: 20191105034138.GF16867@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote:
> That is, TestLib::slurp_file is failing to read a file. Almost
> certainly, "permission denied" doesn't really mean a permissions
> problem, but failure to specify the file-opening flags needed to
> allow concurrent access on Windows. We fixed this in pg_ctl
> itself in commit 0ba06e0bf ... but we didn't fix the TAP
> infrastructure. Is there an easy way to get Perl on board
> with that?

If we were to use Win32API::File so as the file is opened in shared
mode, we would do the same as what our frontend/backend code does (see
$uShare):
https://metacpan.org/pod/Win32API::File
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-11-05 04:19:37 Re: Logical replication wal sender timestamp bug
Previous Message Thomas Munro 2019-11-05 03:04:25 Re: Run-time pruning for ModifyTable