Re: Remove one use of IDENT_USERNAME_MAX

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: peter(dot)eisentraut(at)2ndquadrant(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Remove one use of IDENT_USERNAME_MAX
Date: 2019-10-28 05:10:08
Message-ID: 20191028.141008.1808344564081861818.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

At Sat, 26 Oct 2019 08:55:03 +0200, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in
> IDENT_USERNAME_MAX is the maximum length of the information returned
> by an ident server, per RFC 1413. Using it as the buffer size in peer
> authentication is inappropriate. It was done here because of the
> historical relationship between peer and ident authentication. But
> since it's also completely useless code-wise, remove it.

In think one of the reasons for the coding is the fact that *pw is
described to be placed in the static area, which can be overwritten by
succeeding calls to getpw*() functions. I think we can believe
check_usermap() never calls them but I suppose that some comments
needed..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2019-10-28 05:13:06 Re: [HACKERS] Block level parallel vacuum
Previous Message Kyotaro Horiguchi 2019-10-28 04:39:39 Re: Restore replication settings when modifying a field type