| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Paul Guo <paulguo(at)gmail(dot)com> |
| Subject: | Re: Missing error_context_stack = NULL in AutoVacWorkerMain() |
| Date: | 2019-10-23 01:31:23 |
| Message-ID: | 20191023013111.GA3286@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 21, 2019 at 12:53:27AM -0400, Tom Lane wrote:
> Oh --- looking closer, proc_exit itself will clear error_context_stack
> before doing much. So a problem would only occur if we suffered an error
> during EmitErrorReport, which seems somewhat unlikely. Still, it's bad
> that this code isn't like all the others. There's certainly no downside
> to clearing the pointer.
Good point about index predicates/expressions. There is the elog()
hook as well in the area, and it's hard to predict how people use
that. So applied and back-patched down 9.4.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-10-23 02:16:25 | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Previous Message | David G. Johnston | 2019-10-23 01:06:39 | Re: jsonb_set() strictness considered harmful to data |