Re: Remaining calls of heap_close/heap_open in the tree

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remaining calls of heap_close/heap_open in the tree
Date: 2019-10-17 11:02:05
Message-ID: 20191017110205.fdr43tqkp4m4r2tp@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-10-17 06:58:27 -0300, Alvaro Herrera wrote:
> On 2019-Oct-17, Michael Paquier wrote:
>
> > On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote:
> > > Wonder if it's worth removing the backward compat ones from master? I
> > > don't quite think so, but...
> >
> > I would vote for the removal so as we'll never see that again in
> > core. Let's see what others think here.
>
> Agreed. There are enough other API changes that if an external
> extension wants to keep using heap_* in their code, they can add their
> own defines anyway.

There's plenty extensions that essentially only need to change
heap_open/close to table_open/close between 11 and 12. And it's
especially the simpler ones where that's the case.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-10-17 11:09:19 Re: pgbench - extend initialization phase control
Previous Message Amit Kapila 2019-10-17 10:30:36 Re: [HACKERS] Block level parallel vacuum