| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: v12.0: segfault in reindex CONCURRENTLY |
| Date: | 2019-10-13 23:57:16 |
| Message-ID: | 20191013235716.GA25169@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 13, 2019 at 04:18:34PM -0300, Alvaro Herrera wrote:
> True. And we can copy the resulting comment to the other spot.
>
> (FWIW I expect the crash is possible not just in reindex but also in
> CREATE INDEX CONCURRENTLY.)
I need to think about that, but shouldn't we have a way to reproduce
that case rather reliably with an isolation test? The patch looks to
good to me, these are also the two places I spotted yesterday after a
quick lookup. The only other caller is isTempNamespaceInUse() which
does its thing correctly.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2019-10-14 01:21:20 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Tomas Vondra | 2019-10-13 21:38:08 | Re: CREATE TEXT SEARCH DICTIONARY segfaulting on 9.6+ |