Re: pgsql: Remove pqsignal() from libpq's official exports list.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Christoph Berg <myon(at)debian(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Date: 2019-10-10 03:56:35
Message-ID: 20191010035635.GD1852@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Oct 09, 2019 at 09:37:34AM -0400, Stephen Frost wrote:
> Yes, this is absolutely the right answer, we shouldn't be removing
> symbols without an SONAME bump. If we don't want to bump the SONAME,
> then don't remove the symbol. This is utterly basic proper library
> maintenance and it isn't appropriate to argue that it's about "well,
> your old apps shouldn't exist" because it's blatently our fault for not
> bumping the SONAME, no matter how old the apps are.

+1. If we were to bump the SONAME, more cleanup could be actually
done, and I got some pushback not long ago regarding some undocumented
APIs in libpq that we still ship for the exact same reasons:
https://www.postgresql.org/message-id/7990.1565550764@sss.pgh.pa.us
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-10-10 05:19:41 pgsql: Fix table rewrites that include a column without a default.
Previous Message Peter Eisentraut 2019-10-09 19:36:40 pgsql: Revert "Use libc version as a collation version on glibc systems

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-10-10 04:13:37 Re: dropping column prevented due to inherited index
Previous Message Amit Kapila 2019-10-10 03:07:04 Re: [HACKERS] Block level parallel vacuum