Re: pgsql: Remove pqsignal() from libpq's official exports list.

From: Christoph Berg <myon(at)debian(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Date: 2019-10-09 07:33:54
Message-ID: 20191009073354.GB30556@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Tom Lane 2019-10-08 <9333(dot)1570566305(at)sss(dot)pgh(dot)pa(dot)us>
> Having said all that, if we conclude we can't break compatibility
> with this legacy code quite yet, I'd be inclined to put a
> separate, clearly-marked-as-legacy-code version of pqsignal()
> back into libpq, using the pre-9.3 SA_RESTART semantics.

That would be nice.

> But I'd like some pretty well-defined sunset time for that,
> because it'd just be trouble waiting to happen. When are
> you going to remove 9.2 psql?

Note that this change caused breakage on the wiki.postgresql.org
infrastructure which still had an old 9.2 psql running. It wasn't
Debian's fault that it had not been upgraded yet.

But I refuse to buy the argument that I'm doing something wrong here.
Shared libraries have SONAMEs to prevent *exactly* this kind of
breakage. If you are removing symbols, bump the SONAME.

Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2019-10-09 13:37:34 Re: pgsql: Remove pqsignal() from libpq's official exports list.
Previous Message Michael Paquier 2019-10-09 04:32:26 pgsql: Flush logical mapping files with fd opened for read/write at che

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2019-10-09 08:29:57 Re: maintenance_work_mem used by Vacuum
Previous Message Michael Paquier 2019-10-09 07:18:12 Re: dropping column prevented due to inherited index