Re: Remove some code for old unsupported versions of MSVC

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove some code for old unsupported versions of MSVC
Date: 2019-10-07 06:52:25
Message-ID: 20191007065225.GG14532@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 04, 2019 at 04:35:59PM +0200, Peter Eisentraut wrote:
> As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013,
> which means _MSC_VER >= 1800. This means that conditionals about
> older versions of _MSC_VER can be removed or simplified.
>
> Previous code was also in some cases handling MinGW, where _MSC_VER is
> not defined at all, incorrectly, such as in pg_ctl.c and win32_port.h,
> leading to some compiler warnings. This should now be handled better.

Thanks Peter for cleaning up this code. I have looked at it, did some
testing and it looks good to me. No spots are visibly missing.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-10-07 06:59:16 Re: pgsql: Remove pqsignal() from libpq's official exports list.
Previous Message Michael Paquier 2019-10-07 05:57:14 Re: [PATCH] use separate PartitionedRelOptions structure to store partitioned table options