| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | legrand legrand <legrand_legrand(at)hotmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hooks for session start and end, take two |
| Date: | 2019-10-01 03:17:22 |
| Message-ID: | 20191001031722.GE2781@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 30, 2019 at 02:46:42PM -0300, Fabrízio de Royes Mello wrote:
> Makes sense to me. I become a reviewer and run all tests (make check &&
> make check-world) and everything is ok. Changed status to "ready for
> commiter".
Thanks. There was an extra problem in the module hidden in the logs
of the regression tests: the autovacuum launcher has a backend ID
assigned at the moment of the session end hook (not the start), but it
is connected to no databases so I added a check on that in the start
and end hooks of the module. That's more logic this way anyway as we
run a transaction in the test, and much better than using directly
GetUserIdAndSecContext() which would not assert for an invalid user
ID. And done with e788bd9.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2019-10-01 03:22:27 | Re: Attempt to consolidate reading of XLOG page |
| Previous Message | Alexander Korotkov | 2019-10-01 02:55:26 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock(PG10.7) |