| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Paul Guo <pguo(at)pivotal(dot)io> |
| Cc: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Subject: | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |
| Date: | 2019-09-30 17:13:49 |
| Message-ID: | 20190930171349.GA21905@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
OK, I pushed this patch as well as Alexey's test patch. It all works
for me, and the coverage report shows that we're doing the new thing ...
though only in the case that rewind *is* required. There is no test to
verify the case where rewind is *not* required. I guess it'd also be
good to test the case when we throw the new error, if only for
completeness ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-09-30 17:14:17 | Re: Proposal: Add more compile-time asserts to expose inconsistencies. |
| Previous Message | Anastasia Lubennikova | 2019-09-30 17:03:54 | Re: Building infrastructure for B-Tree deduplication that recognizes when opclass equality is also equivalence |