Re: range_agg

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: range_agg
Date: 2019-09-26 21:13:49
Message-ID: 20190926211349.GA3375@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Paul, I've started to review this patch. Here's a few minor
things I ran across -- mostly compiler warnings (is my compiler too
ancient?). You don't have to agree with every fix -- feel free to use
different fixes if you have them. Also, feel free to squash them onto
whatever commit you like (I think they all belong onto 0001 except the
last which seems to be for 0002).

Did you not push your latest version to your github repo? I pulled from
there and branch 'multirange' does not seem to match what you posted.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Remove-unused-variable.patch text/x-diff 1.1 KB
0002-Silence-compiler-warning.patch text/x-diff 779 bytes
0003-Silence-mixed-declarations-and-code-compiler-warning.patch text/x-diff 1.4 KB
0004-Silence-mixed-declarations-and-code-compiler-warning.patch text/x-diff 6.5 KB
0005-Silence-mixed-declarations-and-code-compiler-warning.patch text/x-diff 2.4 KB
0006-silence-variable-set-but-not-used-compiler-warning.patch text/x-diff 1.1 KB
0007-Fix-uninitialized-variable-warning.patch text/x-diff 800 bytes
0008-Fix-wrong-type-assignment-warning.patch text/x-diff 857 bytes
0009-Fix-crash-in-multirange_intersect_multirange_interna.patch text/x-diff 1.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-09-26 21:24:55 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Ryan Lambert 2019-09-26 21:13:42 Re: FETCH FIRST clause PERCENT option