Re: Refactoring of connection with password prompt loop for frontends

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactoring of connection with password prompt loop for frontends
Date: 2019-09-26 13:06:27
Message-ID: 20190926130627.GA9179@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Sep-26, Michael Paquier wrote:

> On Wed, Sep 25, 2019 at 05:47:39PM -0300, Alvaro Herrera wrote:
> > This patch has been absolutely overlooked by reviewers. Euler, you're
> > registered as a reviewer for it. Will you submit a review soon? :-)
> >
> > It does not currently apply, so if we get a rebase, that'd be good too.
> Here you go. There were four conflicts in total caused by the switch
> to the central logging infra for vacuumlo/oid2name and the
> introduction of recovery_gen.c. No actual changes except the rebase.

Hmm, you have an XXX comment that appears to need addressing; and I'd
add an explanation about the looping behavior to the comment atop the
new function.

I see that vacuumlo and scripts/common retain their "have_password"
variables. That seems to be so that they can reuse one for other
databases. But how does that work with the new routine?

I notice you changed the historical error message

> - pg_log_error("connection to database \"%s\" failed", database);


> + pg_log_error("could not connect to database \"%s\": %s",

The change seems appropriate to me.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-09-26 13:22:42 Re: pgbench - allow to create partitioned tables
Previous Message Antonin Houska 2019-09-26 12:08:33 Re: Attempt to consolidate reading of XLOG page