Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: tomas(dot)vondra(at)2ndquadrant(dot)com, thunder1(at)126(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node
Date: 2019-09-25 03:24:03
Message-ID: 20190925032403.GF1815@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 24, 2019 at 02:48:16PM +0900, Kyotaro Horiguchi wrote:
> Of course I found no *explicit* ones. But I found one
> ereport(DEBUG1 in register_dirty_segment. So it will work at
> least for the case where fsync request queue is full.

Exactly. I have not checked the patch in details, but I think that
we should not rely on the assumption that no code paths in this area do
not check after CHECK_FOR_INTERRUPTS() as smgrtruncate() does much
more than just the physical segment truncation.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-09-25 03:37:13 Re: range test for hash index?
Previous Message Michael Paquier 2019-09-25 03:13:55 Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method