Re: subscriptionCheck failures on nightjar

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: subscriptionCheck failures on nightjar
Date: 2019-09-18 21:58:08
Message-ID: 20190918215808.yonxqgycme6pbctp@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Sep 18, 2019 at 04:25:14PM +0530, Kuntal Ghosh wrote:
>Hello Michael,
>On Wed, Sep 18, 2019 at 6:28 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On my side, I have let this thing run for a couple of hours with a
>> patched version to include a sleep between the rename and the sync but
>> I could not reproduce it either:
>> #!/bin/bash
>> attempt=0
>> while true; do
>> attempt=$((attempt+1))
>> echo "Attempt $attempt"
>> cd $HOME/postgres/src/test/recovery/
>> PROVE_TESTS=t/ make check > /dev/null 2>&1
>> ERRNUM=$?
>> if [ $ERRNUM != 0 ]; then
>> echo "Failed at attempt $attempt"
>> exit $ERRNUM
>> fi
>> done
>I think the failing test is src/test/subscription/t/
>I've tried to reproduce the same failure using your script in OS X
>10.14 and Ubuntu 18.04.2 (Linux version 5.0.0-23-generic), but
>couldn't reproduce the same.

I kinda suspect it might be just a coincidence that it fails during that
particular test. What likely plays a role here is a checkpoint timing
(AFAICS that's the thing removing the file). On most systems the tests
complete before any checkpoint is triggered, hence no issue.

Maybe aggressively triggering checkpoints on the running cluter from
another session would do the trick ...


Tomas Vondra
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-09-18 22:18:13 Re: Optimization of some jsonb functions
Previous Message Melanie Plageman 2019-09-18 21:32:13 Re: Memory Accounting