Re: pg_upgrade check fails on Solaris 10

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Victor Wagner <v(dot)wagner(at)postgrespro(dot)ru>
Subject: Re: pg_upgrade check fails on Solaris 10
Date: 2019-09-18 14:36:00
Message-ID: 20190918143600.GA4211@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Sep-17, Marina Polyakova wrote:

> Hello, hackers!
> We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
> argument to the sed command is not enclosed in quotation marks (see [1]):

Hmm, I'm surprised it has taken this long to detect the problem.

> Attached diff.patch fixes the problem.

I have pushed it to all branches that have src/bin/pg_upgrade (namely,
9.5 onwards), thanks. I hope this won't make the msys/mingw machines
angry ;-)

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-09-18 15:04:13 Re: Nondeterministic collations vs. text_pattern_ops
Previous Message Fujii Masao 2019-09-18 14:34:17 Re: allow online change primary_conninfo