Re: errbacktrace

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: errbacktrace
Date: 2019-09-13 15:54:32
Message-ID: 20190913155432.GA1200@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Aug-20, Peter Eisentraut wrote:

> The memory management of that seems too complicated. The "extra"
> mechanism of the check/assign hooks only supports one level of malloc.
> Using a List seems impossible. I don't know if you can safely do a
> malloc-ed array of malloc-ed strings either.

Here's an idea -- have the check/assign hooks create a different
representation, which is a single guc_malloc'ed chunk that is made up of
every function name listed in the GUC, separated by \0. That can be
scanned at error time comparing the function name with each piece.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v5-0001-Add-backtrace-support.patch text/x-diff 17.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-09-13 15:58:12 Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Previous Message James Coleman 2019-09-13 15:31:49 Re: [PATCH] Incremental sort (was: PoC: Partial sort)