Re: Plug-in common/logging.h with vacuumlo and oid2name

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Plug-in common/logging.h with vacuumlo and oid2name
Date: 2019-09-05 13:59:51
Message-ID: 20190905135951.GA24123@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Patch looks good to me, please push.

Generally speaking I find the 'progname' handling a bit silly (since we
have it both as a variable in each program and also in logging.c
separately), but that's not the fault of this patch, and this patch
doesn't make it worse. That said, I think some other messages in
vacuumlo can be made pg_log_somelevel(), based on occurrences of

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-09-05 14:18:52 changing wal segsize with pg_resetwal
Previous Message Alvaro Herrera 2019-09-05 13:30:32 Re: unexpected rowlock mode when trigger is on the table