Re: Re: Email to hackers for test coverage

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, "ibrar(dot)ahmad" <ibrar(dot)ahmad(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Re: Email to hackers for test coverage
Date: 2019-09-04 04:36:52
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Aug 28, 2019 at 11:27:15AM -0700, Peter Geoghegan wrote:
> Movead is correct -- the NULL handling within
> ApplySortAbbrevFullComparator() cannot actually be used currently. I
> wouldn't change anything about the code, though, since it's useful to
> defensively handle NULLs.

No objections with this line of thoughts. Thanks, Peter. Please note
that I have marked the original patch as committed in the CF app. If
there are tests to improve the coverage, let's do that on a new
thread. I am still not sure where I would put tests dedicated to
abbreviated keys, but let's sort out that if necessary later.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2019-09-04 04:56:18 Re: WIP: Data at rest encryption
Previous Message Michael Paquier 2019-09-04 04:27:40 Re: pg_basebackup -F t fails when fsync spends more time than tcp_user_timeout