|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||Amit Langote <amitlangote09(at)gmail(dot)com>|
|Cc:||Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: remove "msg" parameter from convert_tuples_by_name|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2019-Sep-04, Amit Langote wrote:
> On Wed, Sep 4, 2019 at 3:52 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > On 2019-Aug-07, Amit Langote wrote:
> > > If we're reducing the message string to occur only once in the source
> > > code, can we maybe write it to be more informative? I wonder if users
> > > aren't normally supposed to see this message?
> > Grepping for the messages given to convert_tuples_by_position yields
> > quite a few matches in regression test output, but none for the one in
> > convert_tuples_by_name. This makes me think that it isn't user-visible,
> > unless things go very wrong.
> > Pushed the patch, thanks.
> Thanks. I thought you'd change the ereport to elog while at it.
Oh, that didn't occur to me, but because it has errdetail and an errcode
it'd be more controversial. I don't see any reason to do it, frankly ...
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Masahiko Sawada||2019-09-04 01:43:22||Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2|
|Previous Message||Alvaro Herrera||2019-09-04 01:38:58||Re: Proposal: roll pg_stat_statements into core|