Re: dropdb --force

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com>
Subject: Re: dropdb --force
Date: 2019-09-03 16:46:33
Message-ID: 20190903164633.GA16408@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Jul-25, Pavel Stehule wrote:

> čt 25. 7. 2019 v 5:11 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
>
> > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:

> > * I'm concerned that the proposed syntax is not future-proof.
>
> Can be
>
> DROP DATABASE '(' options ...) [IF EXISTS] name
>
> ok?

Seems weird to me. I'd rather have the options at the end with a WITH
keyword. But that's just me, looking at gram.y for other productions
involving ^DROP.

> I don't think so server side implementation is too helpful - there is lot
> of situations, where DDL command is much more practical.

I tend to agree. Not really a fan of the double-timeout business,
though.

So when are you submitting an updated patch, addressing the other items
that Tom mentions in his review?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-09-03 16:49:11 Re: dropdb --force
Previous Message Ibrar Ahmed 2019-09-03 16:46:13 Re: block-level incremental backup