Re: [PATCH] kNN for btree

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] kNN for btree
Date: 2019-09-02 23:19:48
Message-ID: 20190902231948.GA5343@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Sep-03, Alexander Korotkov wrote:

> I think patches 0001-0008 are very clear and extends our index-AM
> infrastructure in query straightforward way. I'm going to propose
> them for commit after some further polishing.

Hmm. Why is 0001 needed? I see that 0005 introduces a call to that
function, but if attnum == 0 then it doesn't call it. Maybe it was
necessary in an older version of the patch?

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2019-09-02 23:22:05 Re: pg_upgrade version checking questions
Previous Message Alexander Korotkov 2019-09-02 23:11:30 Re: [PATCH] kNN for btree