Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: 2019-08-21 13:49:54
Message-ID: 20190821134954.GA26174@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On 2019-Aug-21, Michael Paquier wrote:

> On Tue, Aug 20, 2019 at 10:40:05PM -0400, Alvaro Herrera wrote:
> >
> > BTW why fprintf? Since you can get into this by careless use of -j,
> > ISTM that this should be a translatable string. I'd consider
> > pg_log_fatal(). Maybe something like "Argument of -j too large for this
> > platform -- try %d", numslots - i.
> If giving a recommendation, shouldn't that be linked only to "i"
> instead? If for example numslots = 1024, but that we get an error
> after allocating 128 slots because of a lack of fds in the range, then
> we would recommend 896, which would still result in an error.

I was too tired last night to think this through properly ... the first
few times I wrote that were even more wrong. "i" seems right.

> I quite like the suggestion from Andres to keep the message simple
> with "too many jobs for this platform's select()". You are indeed
> right about the pg_log_fatal() part here, I have changed the patch to
> do that on my local branch.

Well, it's a user-facing error, so I'd rather make it user-friendly.
It doesn't seem difficult, or unreliable enough not to try.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2019-08-21 14:02:46 Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Previous Message Tom Lane 2019-08-21 13:45:13 Re: BUG #15971: Behaviour of SUBSTR function depending on its arguments