Re: some SCRAM read_any_attr() confusion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some SCRAM read_any_attr() confusion
Date: 2019-08-17 12:57:50
Message-ID: 20190817125750.GB6079@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote:
> I was a bit confused by some of the comments around the SCRAM function
> read_any_attr(), used to skip over extensions.
>
> The comment "Returns NULL if there is attribute.", besides being
> strangely worded, appears to be wrong anyway, because the function never
> returns NULL.

This may have come from an incorrect merge with a past version when
this code has been developed. +1 for me for your suggestions and your
patch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-08-17 13:07:22 Re: default_table_access_method is not in sample config file
Previous Message Peter Eisentraut 2019-08-17 08:11:27 some SCRAM read_any_attr() confusion