| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: errbacktrace |
| Date: | 2019-08-13 13:24:13 |
| Message-ID: | 20190813132413.GA4757@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Aug-13, Peter Eisentraut wrote:
> I have changed the configuration setting to backtrace_functions plural,
> so that you can debug more than one location at once. I had originally
> wanted to do that but using existing functions like
> SplitIdentifierString() resulted in lots of complications with error
> handling (inside error handling!). So here I just hand-coded the list
> splitting. Seems simple enough.
Hmm ... but is that the natural way to write this? I would have thought
you'd split the list at config-read time (the assign hook for the GUC)
and turn it into a List of simple strings. Then you don't have to
loop strtok() on each errfinish().
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2019-08-13 13:50:17 | Re: Global temporary tables |
| Previous Message | Jeremy Finzel | 2019-08-13 12:37:20 | Configuring bgw_restart_time |