Re: Small patch to fix build on Windows

At Fri, 9 Aug 2019 09:56:27 +0300, Dmitry Igrishin <dmitigr(at)gmail(dot)com> wrote in <CAAfz9KPZbPjoWTqOb5moi_YWvdbSjAMZsrVBW0cBw33Q560CLw(at)mail(dot)gmail(dot)com>
> пт, 9 авг. 2019 г. в 05:45, Michael Paquier <michael(at)paquier(dot)xyz>:
> >
> > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> > > This looks nice for a Perl hacker :-). As for me, it looks unusual and
> > > a bit confusing. I never
> > > programmed in Perl, but I was able to quickly understand where the
> > > problem lies due to the
> > > style adopted in other languages, when the contents are enclosed in
> > > quotation marks, and
> > > the quotation marks are escaped if they are part of the contents.
> > > So, should I fix it? Any thoughts?
> >
> > FWIW, I like Alvaro's suggestion about qq{} in this case, as it makes
> > sure that double-quotes are correctly applied where they should.
> The attached 4rd version of the patch uses qq||. I used qq|| instead
> of qq{} for consistency because qq|| is already used in Solution.pm:
>
> return qq|VisualStudioVersion = $self->{VisualStudioVersion}
> MinimumVisualStudioVersion = $self->{MinimumVisualStudioVersion}
> |;

Hmm. qq is nice but '|' make my eyes twitch (a bit). Couldn't we
use other delimites like (), ##, or // ? (I like {} for use in
this patch.)

Any opinions?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center