Re: Small patch to fix build on Windows

Hello.

At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin <dmitigr(at)gmail(dot)com> wrote in <CAAfz9KPVff92Np51DvvCDvqvxVchiuuvJCzz56qtM=N0SUnG8A(at)mail(dot)gmail(dot)com>
> > - if ($lib =~ m/\s/)
> > - {
> > - $lib = '&quot;' . $lib . "&quot;";
> > - }
> > + # Since VC automatically quotes paths specified as the data of
> > + # <AdditionalDependencies> in VC project file, it's mistakably
> > + # to quote them here. Thus, it's okay if $lib contains spaces.
> >
> > I'm not sure, but it's not likely that someone adds it without
> > actually stumbling on space-containing paths with the ealier
> > version. Anyway if we shouldn't touch this unless the existing
> > code makes actual problem.
> So, do you think a comment is not needed here?

# Sorry the last phrase above is broken.

I meant "if it ain't broke don't fix it".

I doubt that some older versions of VC might need it. I confirmed
that the extra &quot; actually harms at least VC2019 and the code
removal in the patch works. As for the replace comment, I'm not
sure it is needed since I think quoting is not the task for
AddLibrary/AddIncludeDir in the first place (and AddIncludeDir
doesn't have the same comment).

Now I'm trying to install VS2015 into my alomost-filled-up disk..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center