From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | dmitigr(at)gmail(dot)com |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Small patch to fix build on Windows |
Date: | 2019-08-07 08:28:51 |
Message-ID: | 20190807.172851.160912433.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
At Tue, 6 Aug 2019 22:50:14 +0300, Dmitry Igrishin <dmitigr(at)gmail(dot)com> wrote in <CAAfz9KO4Nt-kDUKAcEKFND+1LeZ6nH_hjPGamonfTeZLRKz0bg(at)mail(dot)gmail(dot)com>
> The attached self-documented patch fixes build on Windows in case when
> path to Python has embedded spaces.
- $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
+ "\"$solution->{options}->{python}\\python\" -c \"$pythonprog\"";
Solution.pm has the following line:
> my $opensslcmd =
> $self->{options}->{openssl} . "\\bin\\openssl.exe version 2>&1";
AFAICS that's all.
- if ($lib =~ m/\s/)
- {
- $lib = '"' . $lib . """;
- }
+ # Since VC automatically quotes paths specified as the data of
+ # <AdditionalDependencies> in VC project file, it's mistakably
+ # to quote them here. Thus, it's okay if $lib contains spaces.
I'm not sure, but it's not likely that someone adds it without
actually stumbling on space-containing paths with the ealier
version. Anyway if we shouldn't touch this unless the existing
code makes actual problem.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2019-08-07 08:48:48 | s/rewinded/rewound/? |
Previous Message | Amit Langote | 2019-08-07 08:26:31 | Re: Handling RestrictInfo in expression_tree_walker |