| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions |
| Date: | 2019-08-02 23:24:30 |
| Message-ID: | 20190802232430.dbofzp6ovflsywkw@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-08-03 08:22:29 +0900, Ian Barwick wrote:
> What I came up with shoehorned a stripped-down version of the backend
> config parser into fe_utils and provides a function to modify pg.auto.conf
> in much the same way ALTER SYSTEM does, but with only the basic syntax
> checking provided by the parser of course. And for completeness a
> client utility which can be called by scripts etc.
> I can clean it up and submit it later for reference (got distracted by other things
> recently) though I don't think it's a particularly good solution due to the
> lack of actual checks for the provided GUCSs (and the implementation
> is ugly anyway); something like what Andres suggests below would be far better.
I think my main problem with that is that it duplicates a nontrivial
amount of code.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Barwick | 2019-08-02 23:36:13 | Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions |
| Previous Message | Ian Barwick | 2019-08-02 23:22:29 | Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions |