| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: concerns around pg_lsn |
| Date: | 2019-07-31 00:51:30 |
| Message-ID: | 20190731005130.GD1577@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 30, 2019 at 02:22:30PM +0530, Jeevan Ladhe wrote:
> On Tue, Jul 30, 2019 at 9:42 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Agreed about making the code more defensive as you do. I would keep
>> the initialization in check_recovery_target_lsn and pg_lsn_in_internal
>> though. That does not hurt and makes the code easier to understand,
>> aka we don't expect an error by default in those paths.
>>
>
> Sure, understood. I am ok with this.
I am adding Peter Eisentraut in CC as 21f428e is his commit. I think
that the first patch is a good idea, so I would be fine to apply it,
but let's see the original committer's opinion first.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-07-31 00:51:48 | Re: Attached partition not considering altered column properties of root partition. |
| Previous Message | David Fetter | 2019-07-31 00:33:55 | Re: Adding column "mem_usage" to view pg_prepared_statements |